-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus input after submitting riddle #793
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
Oh and btw, if I understood it correctly, when developing cmsch I should commit my branch into staging and not master, right? |
I think this was intentional so they wouldn't be able to spam with holding down Enter, but there are probably better ways to deal with that (debouncing or rate limiting) |
Meanwhile I tried out the qpaweb on mobile. I think it would be a great ux impovement on pc or laptop, but not so much on mobile, since it also brings up the keyboard, and people might want to look at the picture before guessing again. Is there a way to check what kind of device the client is using in React? |
oh I see there's a 1 sec timer after submitting, so they shouldn't be able to spam. btw I think you can solve this just by removing the |
you always have access to the |
Ahh, wonderful solution :D |
Don't forget to rebase your branch onto staging |
any update on this? |
Oh none, I think this will work just fine, I just waited for approval and forgot to close the pr. Btw should I close it myself, or always wait for reviewers with closing pull requests on bigger projects? |
This one is not merged yet, could you mark it as ready, please? |
Don't forget to rebase onto staging too :) |
How can I solve the merge conflicts? Usually there is a merge conflict solver, but I don't see a link to it now. |
c5adc3d
to
839f91e
Compare
I rebased it for you |
Quality Gate passed for 'cmsch-frontend'Issues Measures |
Quality Gate passed for 'cmsch'Issues Measures |
After the user submits the riddle, and it was not correct, the ref to the solutionInput gets focused.
After using the riddles a few times, I noticed that I always had to click back to the input field, after submitting the riddle, even when I didn't press the Submit button, but pressed Enter. This should fix that.